Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in MTData #66

Merged
merged 37 commits into from
Oct 24, 2024
Merged

Fix bug in MTData #66

merged 37 commits into from
Oct 24, 2024

Conversation

kujaku11
Copy link
Contributor

@kujaku11 kujaku11 commented Oct 18, 2024 •
edited
Loading

There is a bug in initializing MTData

Methods need updating.

Added impedance_units to transfer functions
Added invert_impedance to simpeg_2d
Updated simpeg 2D recipe

@codecov Codecov
Copy link

codecov bot commented Oct 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.82386% with 135 lines in your changes missing coverage. Please review.

Project coverage is 34.88%. Comparing base (392a56b) to head (050b731).
Report is 38 commits behind head on main.

Files with missing lines Patch % Lines
mtpy/modeling/simpeg/recipes/inversion_2d.py 15.66% 70 Missing ⚠️
mtpy/modeling/simpeg/data_2d.py 43.67% 49 Missing ⚠️
mtpy/core/mt_data.py 91.66% 4 Missing ⚠️
tests/core/test_mt_data.py 97.45% 3 Missing ⚠️
mtpy/core/mt_stations.py 81.81% 2 Missing ⚠️
mtpy/imaging/plot_pt.py 0.00% 2 Missing ⚠️
mtpy/modeling/simpeg/make_2d_mesh.py 97.75% 2 Missing ⚠️
mtpy/core/mt_dataframe.py 85.71% 1 Missing ⚠️
mtpy/core/transfer_function/base.py 87.50% 1 Missing ⚠️
...py/core/transfer_function/z_analysis/distortion.py 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
+ Coverage   33.66%   34.88%   +1.21%     
==========================================
  Files         146      147       +1     
  Lines       24163    24732     +569     
==========================================
+ Hits         8135     8628     +493     
- Misses      16028    16104      +76
Flag Coverage Δ
tests 34.88% <80.82%> (+1.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kujaku11 kujaku11 marked this pull request as ready for review October 24, 2024 03:34
@kujaku11 kujaku11 merged commit 8784a36 into main Oct 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kujaku11